Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade build scripts #564

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Upgrade build scripts #564

merged 1 commit into from
Nov 2, 2023

Conversation

roastduck
Copy link
Owner

  • Remove explicit invocations on cmake since no longer required after Fully support installing via pip #562.
  • Remove build-time requirement of pybind11-stubgen from pyproject.toml because it breaks CMake's incremental compilation (it breaks the files cached in the build directory).
  • We should check the version of pybind11-stubgen in the future, since we don't support its latest version (added a FIXME comment for now).

@roastduck roastduck added the dependencies Pull requests that update a dependency file label Nov 2, 2023
@roastduck roastduck requested a review from trrbivial November 2, 2023 07:30
@roastduck roastduck merged commit 7d566e4 into master Nov 2, 2023
8 checks passed
@roastduck roastduck deleted the fix-build branch November 2, 2023 23:52
roastduck added a commit that referenced this pull request Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants