Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement real presburger-based CompUniqueBounds. #283

Merged
merged 25 commits into from
Dec 30, 2023
Merged

Conversation

Blealtan
Copy link
Collaborator

Currently only isolated implementation and provide a new abstract interface. Open PR just for CI runs.

@lgtm-com
Copy link

lgtm-com bot commented Nov 24, 2022

This pull request introduces 1 alert when merging 489e687 into e9657aa - view on LGTM.com

new alerts:

  • 1 for Unused import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link

lgtm-com bot commented Nov 25, 2022

This pull request introduces 1 alert when merging fb22584 into e9657aa - view on LGTM.com

new alerts:

  • 1 for Unused import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

src/pass/make_parallel_reduction.cc Dismissed Show dismissed Hide dismissed
src/math/parse_pb_expr.cc Dismissed Show dismissed Hide dismissed
src/math/parse_pb_expr.cc Fixed Show fixed Hide fixed
- Fix return value from CompUniqueBounds when there is no non-trivial
  bounds.
- Fix pass/shrink_var for whether using old shapes for bounds.
- Fix incorrect testing program in 20.pass/test_prop_one_time_use.py::test_thread_local_no_prop
@roastduck roastduck marked this pull request as ready for review December 30, 2023 08:58
@roastduck roastduck added the enhancement New feature or request label Dec 30, 2023
@roastduck roastduck changed the title [WIP] Implement real presburger-based CompUniqueBounds. Implement real presburger-based CompUniqueBounds. Dec 30, 2023
@roastduck roastduck merged commit 67fef0a into master Dec 30, 2023
8 checks passed
@roastduck roastduck deleted the pb-bound branch December 30, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants