New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom trace mode using default base class #4693

Merged

rmosolgo merged 1 commit into master from fix-custom-trace-with-default-base-class

Nov 2, 2023

Owner

rmosolgo commented Nov 1, 2023

Oops -- I knew I was going to need something like this, but I forgot to actually test for it, then I removed it as unused in ef53f44#diff-ca02a7189be9dc9f1c0d328028ba139f8be8da82eca96bbfccd3c098b5ad03f7L173

In a subclass, a custom trace mode should get the same default base trace class as the default mode.


          Fix custom trace mode using default base class

99a2faa

rmosolgo added this to the 2.1.6 milestone

rmosolgo merged commit 6441c0f into master

12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet