Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Warden#get_field in 1.13.x #4676

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Fix Warden#get_field in 1.13.x #4676

merged 2 commits into from
Oct 20, 2023

Conversation

rmosolgo
Copy link
Owner

@rmosolgo rmosolgo commented Oct 20, 2023

Fixes #4602

Schema class methods got a third parameter added, context, to handle dynamic schema member. Instance-based methods (like Schema#get_field) didn't get that new parameter.

I'm adding it here so that the call in Warden#get_field won't raise an error, but the argument is unused.

@rmosolgo rmosolgo added this to the 1.13.20 milestone Oct 20, 2023
@rmosolgo rmosolgo merged commit 0f022d5 into 1.13.x Oct 20, 2023
8 of 12 checks passed
@rmosolgo rmosolgo deleted the fix-warden-get-field-1.13 branch October 20, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant