Rewrite dataloader to use Fiber#transfer #4625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, do u have any news on this PR ? Are u gonna merge it ? |
|
We are also looking forward to turning on non-blocking fibers at Flexhire 🙂 |
|
The reason I paused on this is because I really wanted to get it working with the |
This was referenced Dec 13, 2023
This was referenced Dec 21, 2023
|
This change was rolled back in #4752 because
But, GraphQL-Ruby 2.2.3 will have a much better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to find a way to make GraphQL::Dataloader work with non-blocking fibers that use
.transfer. I tried an incremental approach in #4322 , but it's not really working -- I think I need to rethink how these parts fit together.This is coming along nicely -- it's actually much simpler -- but it doesn't support
blocking: falseyet.