Merge pull request #5080 from amomchilov/use-attr_reader

Use `attr_reader` where applicable
rmosolgo · Sep 2, 2024 · 4836730 · 4836730
2 parents a5e12e8 + fd0c3b4
commit 4836730
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 12 deletions.
diff --git a/lib/graphql/schema/resolver.rb b/lib/graphql/schema/resolver.rb
@@ -409,9 +409,7 @@ def extensions
 
         private
 
-        def own_extensions
-          @own_extensions
-        end
+        attr_reader :own_extensions
       end
     end
   end

diff --git a/spec/graphql/analysis_spec.rb b/spec/graphql/analysis_spec.rb
@@ -523,9 +523,7 @@ def on_enter_field(node, parent, visitor)
           super
         end
 
-        def result
-          @result
-        end
+        attr_reader :result
       end
       class BaseField < GraphQL::Schema::Field
         def initialize(*args, visible: true, **kwargs, &block)

diff --git a/spec/graphql/tracing/statsd_trace_spec.rb b/spec/graphql/tracing/statsd_trace_spec.rb
@@ -9,9 +9,7 @@ def time(key)
         yield
       end
 
-      def timings
-        @timings
-      end
+      attr_reader :timings
 
       def clear
         @timings = []

diff --git a/spec/graphql/tracing/statsd_tracing_spec.rb b/spec/graphql/tracing/statsd_tracing_spec.rb
@@ -9,9 +9,7 @@ def time(key)
         yield
       end
 
-      def timings
-        @timings
-      end
+      attr_reader :timings
 
       def clear
         @timings = []
-Original file line number
+Diff line change
@@ Expand Up / @@ -409,9 +409,7 @@ def extensions @@
             private
-            def own_extensions
-              @own_extensions
-            end
+            attr_reader :own_extensions
           end
         end
       end
@@ Expand Down @@