Add a deprecation warning when .request is returned

rmosolgo · Jan 25, 2024 · 24138c7 · 24138c7
1 parent 930468f
commit 24138c7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/graphql/dataloader/request.rb b/lib/graphql/dataloader/request.rb
@@ -14,6 +14,11 @@ def initialize(source, key)
       def load
         @source.load(@key)
       end
+
+      def load_with_deprecation_warning
+        warn("Returning `.request(...)` from GraphQL::Dataloader is deprecated, use `.load(...)` instead. (See usage of #{@source} with #{@key.inspect}).")
+        load
+      end
     end
   end
 end
diff --git a/lib/graphql/schema.rb b/lib/graphql/schema.rb
@@ -1404,7 +1404,7 @@ def lazy_methods
           else
             @lazy_methods = GraphQL::Execution::Lazy::LazyMethodMap.new
             @lazy_methods.set(GraphQL::Execution::Lazy, :value)
-            @lazy_methods.set(GraphQL::Dataloader::Request, :load)
+            @lazy_methods.set(GraphQL::Dataloader::Request, :load_with_deprecation_warning)
           end
         end
         @lazy_methods