-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite property handling to use a simple table rather than an entity-attribute-value table #110
Conversation
…ed to be updated.
…ed in the test database.
The basic implementation is finished. I've changed the database schema and adapted the code in a minimal way to get everything working, including tests. There is still more work that should be done at some point: optimize the queries to take advantage of the new structure, and remove/simplify some of the existing property handling code. |
TODOs:
|
I already sent an email around about this but it'd good to keep this information in one place. I rewrote the match SQL query by hand to avoid the large inner query that is causing a huge amount of disk usage for covsonar 2 and the results are striking: Empty match (returns the full set of sequences in the database): Mutation and lineage match: So rewriting the queries resulted in 6.2x speedup for the first query and a 10.7x speedup for the second query. The queries themselves are attached. |
Closed because we do not plan to continue covsonar 2 development. |
Some lineage querying is broken, and tests need to be updated.
Not ready yet, but I think it's enough that I can do some basic performance tests to make sure this is worth the effort.