Specify parent window for popups. #3406
Open
+40
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Message boxes without parent are almost always a mistake. Such message boxes * Aren't properly position on top of current window, instead they get placed in the corner of screen possibly away from main window. * They get treated as separate window by window manager, but they still prevent proper interaction with main window. If you alt tab the message box can get lost, resulting in confusing behavior where you don't know why you can't interact with main window.
wargio
changed the title
wargio
approved these changes
Jan 22, 2025
wargio
reviewed
Jan 22, 2025
| @@ -66,7 +66,7 @@ void WelcomeDialog::onLanguageComboBox_currentIndexChanged(int index) | |||
| QString language = ui->languageComboBox->itemText(index); | |||
| Config()->setLocaleByName(language); | |||
|
|
|||
| QMessageBox mb; | |||
| QMessageBox mb(this); | |||
There was a problem hiding this comment.
isn't the main window not available when the welcome dialog is up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Message boxes without parent are almost always a mistake. Such message boxes
This PR doesn't fix all such cases in Cutter, but at least it cleans up a good portion of easy ones.
Test plan (required)
Closing issues