-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify python binding include handling #3268
Conversation
* remove duplicate code introduced in rizinorg#2952 * specify include path using multiple include-path lines instead instead of single line with with directories separated by ; or :
this builds fine for me on NixOS with Pyside6. And yes, Shiboken2 requires Python 3.10 |
a214abe
to
ca1a2e3
Compare
ca1a2e3
to
380964e
Compare
As @lilyinstarlight mentioned, this fixes the Nix build on Linux, but not on Darwin. |
fe94bd4
to
435d63d
Compare
435d63d
to
ca5949d
Compare
@lilyinstarlight Can you retest with Nix on macOS? Tested that homebrew still works on my system. It ended up being based on QT6_INSTALL_PREFIX anyway, but at least now it's closer to what pyside is doing. Definition of QT_FRAMEWORK_INCLUDE_DIR |
Yep, the latest commit seems to work great for building with Qt6 from Nix now. Thank you! ❤️ |
Your checklist for this pull request
Detailed description
Looks like shiboken6 slightly changed the rules of bindings.txt and now include-path entry doesn't allow multiple include directories. Generating multiple include-path entries, one for each directory seems to work fine both for shiboken6 an shiboken2.
I am not too happy about the way I handled macOS include path, but I guess it's no worse than what was already there for qt5 (likely due to similar reasons).
Test plan (required)
* had to comment out
Py_LIMITED_API
seems like shiboken2 isn't tested against latest python . Otherwise it error on this code in shiboken2/pep384impl.h :Closing issues
closes #3188