Temporary fix for command output to console widget. #3265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karliss
force-pushed
the
console-output
branch
from
c97a670 to
1a78ac9
Compare
* partially revert rizinorg#3193 - printing the terminal escape sequences directly to text widget causes more issues than the tab problem it tried to fix * move the conversation to html from command task to the console widget * add hack converting tab to multiple spaces
karliss
force-pushed
the
console-output
branch
from
1a78ac9 to
9a5d33a
Compare
XVilka
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
#3193 fixed the tab issue but it broke handling of any formatting resulting in many commands look like this:
Which in my opinion is completely unusable.
Restored the ansi to html conversion and added a hack for handling '\t' so that there is at leas some indendation when used at the start of line.
I have plans for improving the terminal widget that I will hopefully find time to implement in next couple of months.
Test plan (required)
!printf '\tabc\n'should print abc with some indendtation?should print help with correctly colored output instead of raw terminal codes as plaintexttc __div_tshould print the struct fields with some indendationClosing issues