Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rotation offset used in neon #3915

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

yinanazhou
Copy link
Contributor

  • Set rotate to 0 if not has rotate
  • Add clef offset when using default clef

refs: DDMAL/Neon#1254, DDMAL/Neon#1226

src/facsimilefunctor.cpp Outdated Show resolved Hide resolved
- Use `GetDrawingRotation()` instead of `GetDrawingRotate()`
- Fix clef offset calculation in `AdjustPitchFromPosition()`
- Adjust offset for custos insertion

refs: DDMAL/Neon#1254, DDMAL/Neon#1226
@yinanazhou yinanazhou changed the title fix: insertion offset in neon fix: rotation offset used in neon Jan 16, 2025
@lpugin lpugin merged commit 86add81 into rism-digital:develop Jan 16, 2025
5 checks passed
@yinanazhou yinanazhou deleted the insert-fix branch January 27, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants