-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lyric improvements #3905
Merged
Merged
Lyric improvements #3905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahankinson
reviewed
Jan 6, 2025
ahankinson
reviewed
Jan 6, 2025
ahankinson
reviewed
Jan 6, 2025
ahankinson
approved these changes
Jan 6, 2025
Co-authored-by: Andrew Hankinson <[email protected]>
Co-authored-by: Andrew Hankinson <[email protected]>
ahankinson
reviewed
Jan 6, 2025
src/alignfunctor.cpp
Outdated
} | ||
if ((versePlace != STAFFREL_above) && !alignment->GetVersePositionBelow(verseNumber, verseCollapse)) { | ||
alignment->AddVerseN(verseNumber, verse->GetPlace()); | ||
if (!alignment->GetVersePositionAbove(verseNumber, verseCollapse)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry -- just re-looking. One is GetVersePositionAbove
and one is GetVersePositionBelow
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it was actually correct. Reverted.
This reverts commit 7bafbe8.
ahankinson
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for lyrics above the staff encoded with
verse@place="above"
. The lyrics placed above the staff have the verse@n="1"
at the top - the further away from the staff. The--lyric-verse-collapse
applies in the same way as below.The PR also adds a
--lyric-height
option for specifying the verse line height in MEI units. The default value is0.0
indicating that the normal text height should be used (as before).Example above with
--lyric-height 6.0
Closes #3635 and #3640. Still marked as draft since I am not sure the
--lyric-height
in MEI units is really appropriate.