Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Change appogiatura groups to y #114

Closed
wants to merge 3 commits into from
Closed

Conversation

ahankinson
Copy link
Contributor

Note that the Verovio code remains the same so that the examples render correctly. This will be addressed in #89.

Fixes #113

Note that the Verovio code remains the same so that the examples render correctly. This will be addressed in #89.

Fixes #113
Copy link

github-actions bot commented May 29, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-03 15:34 UTC

@ahankinson ahankinson requested a review from lpugin July 3, 2024 11:29
# Conflicts:
#	v2/changes.html
#	v2/index.html
v2/changes.html Outdated
Comment on lines 189 to 191
</section>
<section>
<h3>Appogiatura Group Opening Character</h3>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation looks wrong

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, working on it

ahankinson added a commit that referenced this pull request Jul 3, 2024
Replaces #114 due to complex conflicts.

Fixes #113.
@ahankinson
Copy link
Contributor Author

Fixing the conflicts was a big headache, so I simply re-did the change in #143 . Closing this one.

@ahankinson ahankinson closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace qq as start of appogiatura group
2 participants