Deploy preview for PR 110 🛫

rism-digital · Jul 15, 2024 · f9ae3fb · f9ae3fb
1 parent 489a4b4
commit f9ae3fb
Show file tree

Hide file tree

Showing 7 changed files with 1,637 additions and 1,472 deletions.
diff --git a/...964a1e325ed338ecd63a990839efa6ecdd023.idx → ...e4e256db2022cde860fee7431094e5989400b.idx b/...964a1e325ed338ecd63a990839efa6ecdd023.idx → ...e4e256db2022cde860fee7431094e5989400b.idx
diff --git a/...64a1e325ed338ecd63a990839efa6ecdd023.pack → ...4e256db2022cde860fee7431094e5989400b.pack b/...64a1e325ed338ecd63a990839efa6ecdd023.pack → ...4e256db2022cde860fee7431094e5989400b.pack
diff --git a/...964a1e325ed338ecd63a990839efa6ecdd023.rev → ...e4e256db2022cde860fee7431094e5989400b.rev b/...964a1e325ed338ecd63a990839efa6ecdd023.rev → ...e4e256db2022cde860fee7431094e5989400b.rev
diff --git a/pr-preview/pr-110/static/js/verovio-rendering.js b/pr-preview/pr-110/static/js/verovio-rendering.js
@@ -30,7 +30,6 @@ document.addEventListener("DOMContentLoaded", (event) => {
 
                 for (let column of row.children)
                 {
-
                     if (column && column.classList.contains("notation-code"))
                     {
                         let paeCode = column.querySelector("script").textContent;
@@ -45,6 +44,18 @@ document.addEventListener("DOMContentLoaded", (event) => {
                     {
                         column.innerHTML = verovioSvg;
                     }
+                    else if (column.classList.contains("rendered-notation"))
+                    {
+                        // This allows for both the code and the output to be shown in the same cell.
+                        let paeCode = column.querySelector("script").textContent;
+                        let loadSuccess = tk.loadData(JSON.stringify(JSON.parse(paeCode)));
+
+                        if (loadSuccess)
+                        {
+                            verovioSvg = tk.renderToSVG();
+                            column.innerHTML = verovioSvg;
+                        }
+                    }
                 }
             }
         }

diff --git a/pr-preview/pr-110/v2/changes.html b/pr-preview/pr-110/v2/changes.html
@@ -164,6 +164,46 @@ <h3>Removal of Coded Validity Note</h3>
                     explanatory notes in a notes field.
                 </p>
             </section>
+            <section>
+                <h3>Alternating Time Signatures</h3>
+                <p>
+                    Previously, alternating time signatures were separated by a
+                    space character. This caused some ambiguities since the
+                    space character was used as a separator for clef, key, and
+                    time changes inline.
+                </p>
+                <p>
+                    In Version 2 this has been changed to a vertical bar,
+                    <code>|</code>.
+                </p>
+            </section>
+            <section>
+                <h3>Mensural Notation</h3>
+                <p>
+                    Previously, the <code>+</code> character was used in clefs
+                    to indicate the staff should be rendered in mensural notation.
+                    Due to the same problems in encoding that had us remove it for ties,
+                    the <code>+</code> character was replaced with a <code>*</code>
+                    character in the clef for indicating mensural notation.
+                </p>
+            </section>
+            <section>
+                <h3>Appogiatura Group Opening Character</h3>
+                <p>
+                    Previously the characters <code>qq</code> were used to start
+                    an appogiatura (a.k.a grace note) group. However, this was
+                    the only instance in the Plaine &amp; Easie Code where two
+                    characters were used to start a group. It also meant that
+                    parsing the code was a bit more difficult, since it created
+                    ambiguities between a single `q`, or a single appogiatura
+                    notes, or a group of notes.
+                </p>
+                <p>
+                    In Version 2 the start of an appogiatura group is now
+                    signalled by the lower-case letter <code>y</code>. It is
+                    still ended by the lower-case letter <code>r</code>.
+                </p>
+            </section>
         </section>
         <section>
             <h2>New Features</h2>
@@ -180,6 +220,35 @@ <h2>Clarifications</h2>
             <section>
                 <h3>Order of elements within a note</h3>
             </section>
+            <section>
+                <h3>Key and Mode</h3>
+                <p>
+                    The ability to explicitly state key and / or mode in Plaine &amp; Easie was not included
+                    in Version 2.
+                </p>
+                <p>
+                    The status of this ability was unclear. MARC21 (<code>$r</code>) and UNIMARC permit the encoding
+                    of key and mode, and indeed the MARC21 documentation states that the format of this field comes
+                    from the Plaine &amp; Easie Code. However, the latest updates to Version 1 of the Code did not
+                    actually specify this format.
+                </p>
+                <p>
+                    The ability to encode the key or mode of a piece was available in the initial versions of the
+                    Plaine &amp; Easie Code, but the format of this field was not strictly defined.
+                </p>
+                <p>
+                    It was decided to not formalize this field in Version 2 of the Code. The judgement of a major
+                    or a minor key is not strictly necessary for capturing the notation of an incipit, and instead is
+                    something that should be captured in an explanatory note or a dedicated cataloguing field. The
+                    application of this field, particularly in the capture of non-CWMN music, would also require
+                    expanding the format and validation of the values beyond a simple rubric.
+                </p>
+                <p>
+                    The effect of this change may be that the subfield remains available in MARC21 and UNIMARC, but the
+                    format is no longer defined in reference to the Plaine &amp; Easie Code.
+                </p>
+            </section>
+
         </section>
     </body>
 </html>