Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor series of visit_stream_node method #20313

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Jan 26, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Currently we have only a visit_stream_node method to visit the stream node, which takes the mutable reference of StreamNode. However, in some scenarios we only have immutable reference to the stream node, which forces us to unnecessarily take the mutable reference of stream node.

In this PR, we change the visit_stream_node to visit_stream_node_mut, and provide a counterpart method visit_stream_node to only take the immutable reference of stream node.

Besides, the two visit_stream_node_xxx methods are only a special case of visit_stream_node_cont_xxx, which always returns true in the closure passed to visit_stream_node_cont_xxx. Therefore, we change to call the visit_stream_node_cont_xxx in visit_stream_node_xxx instead of implementing by themselves.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Copy link
Contributor

@shanicky shanicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@shanicky shanicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wenym1 wenym1 added this pull request to the merge queue Jan 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 26, 2025
@wenym1 wenym1 added this pull request to the merge queue Jan 26, 2025
Merged via the queue into main with commit f6bebea Jan 26, 2025
32 of 33 checks passed
@wenym1 wenym1 deleted the yiming/visit-stream-node-refactor branch January 26, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants