refactor: refactor series of visit_stream_node method #20313
Merged
+49
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Currently we have only a
visit_stream_node
method to visit the stream node, which takes the mutable reference ofStreamNode
. However, in some scenarios we only have immutable reference to the stream node, which forces us to unnecessarily take the mutable reference of stream node.In this PR, we change the
visit_stream_node
tovisit_stream_node_mut
, and provide a counterpart methodvisit_stream_node
to only take the immutable reference of stream node.Besides, the two
visit_stream_node_xxx
methods are only a special case ofvisit_stream_node_cont_xxx
, which always returns true in the closure passed tovisit_stream_node_cont_xxx
. Therefore, we change to call thevisit_stream_node_cont_xxx
invisit_stream_node_xxx
instead of implementing by themselves.Checklist
Documentation
Release note