-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drop connector for table with connector #20023
base: main
Are you sure you want to change the base?
Conversation
replacement for #19871 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also test the behavior on tables with external-resolved schema (i.e., schema registry)? I believe #20131 will be a pre-requisite.
WITH ( | ||
${RISEDEV_KAFKA_WITH_OPTIONS_COMMON}, | ||
topic = 'test_alter_table_drop_connector') | ||
FORMAT PLAIN ENCODE JSON; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this shared source? Can you also add a test case for some non-shared source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The feature is dedicated to table with a connector (dedicate source). I believe the source behavior remains the same.
This pull request has been modified. If you want me to regenerate unit test for any of the files related, please find the file in "Files Changed" tab and add a comment |
I know it has been a while, added now. Happy CNY. |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
Documentation
Release note
new syntax for dropping connector part of a table
only allow for table with associate source, not works for plain table and CDC table.