Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EtriggerTest assuming that NULL causes a trap #579

Merged

Conversation

Wren6991
Copy link
Contributor

Currently the test is broken on systems which map address 0 normally. There is already a mechanism for the test target to supply a known-bad address, so use that address if it is provided.

There is already a mechanism for the test target to supply a known-bad
address, so use that address if it is provided.
Copy link
Collaborator

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This strikes me as brittle, but I think it’s fine as a workaround.

@aswaterman aswaterman merged commit 2f97bab into riscv-software-src:master Aug 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants