refactor: account and token header tsx and hooks #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinr1234
approved these changes
Apr 12, 2023
| paychannels: { | ||
| // eslint-disable-next-line camelcase | ||
| total_available: string | ||
| channels: any[] |
There was a problem hiding this comment.
The previous definition was PropTypes.shape({ length: PropTypes.number }). No other properties are referenced so I figured any[] array matches that. This might be something to address when following up on #587.
| export default connect( | ||
| (state) => ({ | ||
| language: state.app.language, | ||
| (state: any) => ({ |
There was a problem hiding this comment.
It is just a mapping and will soon go away when redux is fully removed. The account and token pages are the last ones using redux for data. The other redux usages will be removed with the new header.
| } | ||
|
|
||
| export default connect( | ||
| (state) => ({ | ||
| language: state.app.language, | ||
| (state: any) => ({ |
There was a problem hiding this comment.
Same answer as <AccountHeader>.
jonathanlei
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
<AccountHeader>and<TokenHeader>use typescript and hooksFixes #476 and related to #554
Context of Change
With the new language picker all updates to language happen directly through i18n-next. All references to language now come through the
useLanguagehook instead of redux.In order to use the hook
<TokenHeader>had to be refactored to a functional component.<AccountHeader>is a very similar component (<TokenHeader>was based on it) so it make sense to complete the Typescript refactor of that component.While setting up the component's types I fixed #476 since I did not want incorrect types. Additionally
<TokenHeader>had many props defined that were copied from<AccountHeader>but are never returned bygetToken.Type of Change
TypeScript/Hooks Update