Add support for setting check_interval

[fkleon]

Add support to set check_interval in the global config section.

check_interval: Defines the interval length, in seconds, between the runner checking for new jobs.
The default value is 3. If set to 0 or lower, the default value is used.

See https://docs.gitlab.com/runner/configuration/advanced-configuration.html#the-global-section

This defaults to 0 which matches the default auto-generated config, and simply causes GitLab runner to use its default value (see above). So this shouldn't cause any change in behaviour for existing users of this role.

[fkleon]

@guenhter just wondering if you can have another look at this?

[guenhter]

@fkleon Thx for this contribution

maybe you can keep your eyes open for incoming issues which might be caused by a this change.

[nvzkupu]

This seems to break windows gitlab-runner deploys.

Even without adding gitlab_runner_check_interval: to my vars file and/or inventory, I get the following error when attempting to deploy a windows runner:

TASK [gitlab-runner : (Windows) Set check_interval option] *********************
fatal: [rmx-win-nv-01]: FAILED! => {"msg": "The powershell shell family is incompatible with the sudo become plugin"}

I tried explicitly setting the variable as gitlab_runner_check_interval: 30, but still get the same output.

Everything up until this point in my ansible run with this role completes normally.

Please see the included file for the run log:
ansible_output.txt

Reverting to v2.0.3 fixed this problem, so it does seem to be related to this change.

[fkleon]

@nvzkupu I indeed had no way to test this on Windows, sorry!

Looks like the Windows tasks may not need to change user with become. Can you try removing the following line:

ansible-gitlab-runner/tasks/global-setup-windows.yml

Line 34 in 68f5f8e

become: "{{ gitlab_runner_system_mode }}"

If that works, I'm happy to provide another pull request.

[nvzkupu]

No worries at all!

Thank you for responding so quickly. 😄

I will give this a shot when I am back at work.

[shock0572]

@fkleon I can confirm for my colleague @nvzkupu
removing that line works like a charm

[fkleon]

@nvzkupu @shock0572 Thanks for confirming! I submitted a PR with the fix here: #345