Battery Docklet UPower Implementation #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How could i miss this idea? I solved the same issue but much more brutally. This is the good solution :) How come it is not yet merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
The battery docklet was showing "battery-missing" icon on my laptop. Upon inspection, I found that my machine has "BAT1" as default battery and no "BAT0" was present, but the docklet was only implemented to show "BAT0" information.
To fix this issue, I have written my own battery docklet implementation using UPower DBus interface. I have only implemented the features which are present in the currently existing battery docklet. However, since I am fetching the icon name right from the UPower interface, the icon shows up a bit differently than the currently existing battery docklet.
Please have a look and let me know if there is any improvement to be made.