Bug #1896297: Battery docklet hard coded to a battery that may not be… #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… present This change makes the battery name user settable. The next change will be to properly enumerate the batteries so that we do not rely on user settings.
zquestz
reviewed
Dec 16, 2024
| { | ||
| public class BatteryPreferences : DockItemPreferences | ||
| { | ||
| [Description(nick = "battery-name", blurb = "The name of the battery unit under /sys/class/powe_supply (default=BAT0)")] |
|
right
Den mån 16 dec. 2024 21:38Josh Ellithorpe ***@***.***> skrev:
… ***@***.**** commented on this pull request.
------------------------------
In docklets/Battery/BatteryPreferences.vala
<#11 (comment)>:
> +// Plank is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with this program. If not, see <http://www.gnu.org/licenses/>.
+//
+
+using Plank;
+
+namespace Docky
+{
+ public class BatteryPreferences : DockItemPreferences
+ {
+ [Description(nick = "battery-name", blurb = "The name of the battery unit under /sys/class/powe_supply (default=BAT0)")]
This should be power_supply right?
—
Reply to this email directly, view it on GitHub
<#11 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJ5CJK3O6AS6DFIPLLTGY32F424JAVCNFSM6AAAAABTW6QIM6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMBXGMYTINRTGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… present
This change makes the battery name user settable. The
next change will be to properly enumerate the batteries so that we do
not rely on user settings.