Fix: Handle Mountain Day Holiday Correctly in Jp #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the correct handling of the Mountain Day holiday in the calendar library. Based on the information provided on the Japanese government's website (https://www8.cao.go.jp/chosei/shukujitsu/gaiyou.html), the changes are as follows:
The Func field has been updated to handle the special cases:
In 2020, Mountain Day was observed on August 10.
In 2021 and onwards, Mountain Day is observed on August 8.
For all other years, Mountain Day is observed on the standard date of August 11.
These changes ensure that the calendar library accurately reflects the changes to the Mountain Day holiday over the years, as per the Japanese national holiday law.