Fix deserialization of sliced bit arrays

richard-viney · Jun 19, 2024 · d2369a0 · d2369a0
1 parent a4ee080
commit d2369a0
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/ieee_float_js.mjs b/src/ieee_float_js.mjs
@@ -71,12 +71,12 @@ function to_bytes_32(f, littleEndian) {
   return new BitArray(u8Array);
 }
 
-function from_bytes_32(f, littleEndian) {
-  if (f.length !== 4) {
+function from_bytes_32(bitArray, littleEndian) {
+  if (bitArray.length !== 4) {
     return new Error(Nil);
   }
 
-  const view = new DataView(f.buffer.buffer);
+  const view = new DataView(bitArray.buffer.buffer, bitArray.buffer.byteOffset);
 
   return view.getFloat32(0, littleEndian);
 }
@@ -90,12 +90,12 @@ function to_bytes_64(f, littleEndian) {
   return new BitArray(u8Array);
 }
 
-function from_bytes_64(f, littleEndian) {
-  if (f.length !== 8) {
+function from_bytes_64(bitArray, littleEndian) {
+  if (bitArray.length !== 8) {
     return new Error(Nil);
   }
 
-  const view = new DataView(f.buffer.buffer);
+  const view = new DataView(bitArray.buffer.buffer, bitArray.buffer.byteOffset);
 
   return view.getFloat64(0, littleEndian);
 }