Generate SbatLevel Metadata from SbatLevel_Variable.txt #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsetje
force-pushed
the
generate_sbat_levels
branch
5 times, most recently
from
d3e5f8c to
8f0b96c
Compare
|
I failed to notice that the initial PR had broken out of place build. Fixed now. There is still some breakage if I build in place and then out of place without cleaning in place. Please let me know if we want that to work and I'll figure that out. |
jsetje
force-pushed
the
generate_sbat_levels
branch
2 times, most recently
from
c3c29dc to
1684f16
Compare
Add revocations for - January 2024 shim CVEs - October 2023 grub CVEs - Debian/Ubuntu (peimage) CVE-2024-2312 to SbatLevel_Variable.txt. This was missed when they were commited to include/sbat_var_defs.h Signed-off-by: Jan Setje-Eilers <[email protected]>
This adds the utility program generate_sbat_var_defs, which can be used to generate the sbar_var_defs.h header file from the human readable SbatLevel_Variable.txt file. Signed-off-by: Jan Setje-Eilers <[email protected]>
Build changes to generate include/generated_sbat_var_defs.h from SbatLevel_Variable.txt and use that header file. From here on forward SbatLevel_Variable.txt should be the only place a new revocation needs to be recorded. Signed-off-by: Jan Setje-Eilers <[email protected]>
Comments to clarify that revocations should only be recorded in SbatLevel_Variable.txt and not in any other header files. Signed-off-by: Jan Setje-Eilers <[email protected]>
vathpela
force-pushed
the
generate_sbat_levels
branch
from
1684f16 to
880f69f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes SbatLevel_Variable.txt the single source of truth for SbatLevel metadata and generates the header file from it.