Fix parallel build of gnu-efi #643
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepio
added a commit
to flatcar/scripts
that referenced
this pull request
Feb 29, 2024
The bundled gnu-efi build is implemented in a buggy way that can break when built in parallel. We've hit this in the nightly sdk build. Add a patch for it. The patch has been posted upstream at rhboot/shim#643. Signed-off-by: Jeremi Piotrowski <[email protected]>
2 tasks
jepio
added a commit
to flatcar/scripts
that referenced
this pull request
Feb 29, 2024
The bundled gnu-efi build is implemented in a buggy way that can break when built in parallel. We've hit this in the nightly sdk build. Add a patch for it. The patch has been posted upstream at rhboot/shim#643. Signed-off-by: Jeremi Piotrowski <[email protected]>
jepio
added a commit
to flatcar/scripts
that referenced
this pull request
Feb 29, 2024
The bundled gnu-efi build is implemented in a buggy way that can break when built in parallel. We've hit this in the nightly sdk build. Add a patch for it. The patch has been posted upstream at rhboot/shim#643. Signed-off-by: Jeremi Piotrowski <[email protected]>
|
"4 years ago" does indeed seem like it's a long time, but quite a few of our consumers are stuck (for now) on make 3.82. Is there another way we can avoid this behavior? |
|
I'm not sure I follow why back grounding that invocation would make things more rather than less deterministic. |
|
This isn't backgrounding, it's defining a grouped target:
https://www.gnu.org/software/make/manual/html_node/Multiple-Targets.html
…On Tue, Jan 21, 2025, 04:59 Jan Setje-Eilers ***@***.***> wrote:
I'm not sure I follow why back grounding that invocation would make things
more rather than less deterministic.
—
Reply to this email directly, view it on GitHub
<#643 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABXINVT7GBB4H32OGSZE2LD2LXA3DAVCNFSM6AAAAABVRSKAMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBTGYYDQNRUGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
When building with make 4.4.1, gnu-efi may be built twice and in parallel: $ make -n -j ARCH=x86_64 2>&1 | tee build.log $ grep -e 'make -C gnu-efi' build.log make -C gnu-efi \ make -C gnu-efi \ This has been seen to cause linking failures when building libgnuefi.a because some object files may end up truncated. The reason for this is that make interprets multiple targets in the same rule as independent and can run the rule multiple times. The solution is to define a grouped target with &:, which causes make to behave the way one expects: runs the rule once and expects it to create all targets. Grouped target support was added in make 4.3 released 4 years ago. Signed-off-by: Jeremi Piotrowski <[email protected]>
vathpela
force-pushed
the
makefile-fix
branch
from
f100876 to
dbd1d1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with make 4.4.1, gnu-efi may be built twice and in parallel:
This has been seen to cause linking failures when building libgnuefi.a because some object files may end up truncated.
The reason for this is that make interprets multiple targets in the same rule as independent and can run the rule multiple times. The solution is to define a grouped target with &:, which causes make to behave the way one expects: runs the rule once and expects it to create all targets.
Grouped target support was added in make 4.3 released 4 years ago.