-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to link against upstream espeak-ng #1
base: master
Are you sure you want to change the base?
Conversation
Following up on a related discussion over here, this PR was changed to a more robust flow, the original implementation can be reviewed on this branch. |
Unless I'm missing something, this seems to not preserve punctuation (which is the reason for the espeak-ng fork). The problem is that The previous solution looked like it would do the right thing, despite being less robust. |
Almost :) Both solutions do preserve punctionation, the difference is that the new solution does not outsource punctuation from espeak-ng, thus providing a hack-free solution at the cost of being marginally less flexible. However, I did check the espeak-ng punctuation code and for the cases handled by piper-phonemize the chosen manual implementation should not be signifficantly less complete. |
My tests fail though when using this PR and espeak-ng 1.51. Have they changed things in a later release? |
Sorry for the late reply, work came along! Indeed, the new implementation was not handling the case where Should be fixed with c46ba6e, |
Great, I'll check again. Thanks! |
9c6c016
to
80ad15e
Compare
@synesthesiam FYI, PR was rebased on the latest master branch :) |
is this going to be merged? |
This PR allows to link piper-phonemize with the unmodified upstream version of espeak-ng.
Tested and working on glibc and musl.