Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logic to exclude tags/labels in plex #49

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

fastrack20
Copy link
Contributor

Noticed that excluding tags/labels in Plex wasnt implimented so I used your framework and added this functionality. New to this, so if I need to make any changes please let me know

@rfsbraz
Copy link
Owner

rfsbraz commented Nov 29, 2023

Hi! First of all, thanks for this! So tags was an early idea that I dropped because of how differently they are handled in Radarr/Sonarr vs Plex (tags in *arr, labels in plex)

I'm ok with adding this but I would change the name to "plex_labels" to make it obvious. There is a ongoing feature to try and make it more obvious what you are setting, but that will take a bit longer. If you rename it and maybe update the docs if you can, I'm happy to get this in!

@rfsbraz rfsbraz merged commit dd7112c into rfsbraz:develop Nov 30, 2023
2 of 3 checks passed
@rfsbraz
Copy link
Owner

rfsbraz commented Nov 30, 2023

That's in!

@rfsbraz
Copy link
Owner

rfsbraz commented Nov 30, 2023

New release done: v0.0.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants