fix: bin function
#305
Merged
fix: bin function
#305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The vignette is updated and the unit test are all good for the So the PR is ready for merging ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to issue #303, this pull request add the argument
zero.rmwithTRUEas a default.The code and documentation updated.
I had to fiddle with the test files because the tests were made with the assumptions that the 0 would be kept.
For now I just added zero.rm = FALSE and added code chunk to check that the bins of intensity 0 are being removed.
See the comment for one thing that I am a bit confused about.
I can also change all the tests if you think it's better.