Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter scalePeaks to plotSpectraMirror #116

Merged
merged 6 commits into from
May 16, 2024
Merged

Add parameter scalePeaks to plotSpectraMirror #116

merged 6 commits into from
May 16, 2024

Conversation

jorainer
Copy link
Member

This PR adds a parameter scalePeaks to plotSpectraMirror,MatchedSpectra that allows to scale the peak intensities before plotting.

Copy link
Collaborator

@philouail philouail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks all good to me, and definitely necessary to prevent extra code, but is there a reason why the default is not "TRUE" ? From what i've seen it's pretty necessary all the time and for example in matchms it is one of the "basic" filtering.

@jorainer
Copy link
Member Author

thanks for the review @philouail - the reason to have the default scalePeaks = FALSE to not change the default behavior of the function. So, people that used the function before would still get the same results. Some might be worried/confused if the results changed from one version to the next.

@jorainer jorainer merged commit b96137d into main May 16, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants