Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: declarations may become undefined #4

Closed
wants to merge 3 commits into from

Conversation

ericfong
Copy link

No description provided.

@bclinkinbeard
Copy link
Contributor

How does that end up being the case? If it's a valid scenario, I think I'd prefer to just terminate early via if (!declarations) return;

@ericfong
Copy link
Author

Basically a fix for #2 , we can change that to if (!declarations) return;

@bclinkinbeard
Copy link
Contributor

Cool. If you want to update the PR I will merge and publish

@ericfong
Copy link
Author

Done!

rework-assets also depend on this module, which also block my webpack sass building

@bclinkinbeard
Copy link
Contributor

Landed as 251381a, published as 1.0.2

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants