Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error when freeipa transforms external trusted user name when adding them to a group #39

Merged

Conversation

infra-monkey
Copy link
Contributor

Fixes #21

When adding a trusted to an external group, multiple formats are allowed DOMAIN\User, DOMAIN\group , username@domain and it is case insensitive.
However the added name is transformed to a lowercase upn format username@domain
When a transformation of the name happens during the add, the creation of the membership succeeds on freeipa but the read operation fails on the next step because there is a mismatch between the resource declaration and the response from freeipa.

With this fix, I check after creation that the name defined in the resource is defined as a member of the group responded by freeipa. If not, I delete the user membership in freeipa and exit without saving the resource in the state.
If the name is a member of the group, then, I continue as normal and save the resource in the state.

This is implemented only for external user group member ship.

@RomanButsiy RomanButsiy merged commit 368cff5 into rework-space-com:main Sep 27, 2024
1 check passed
@infra-monkey infra-monkey deleted the fix/trust-ext-member branch November 2, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional functionality to work with groups
2 participants