Skip to content

Commit

Permalink
Add a NotImplementedError warning to celery health check (#201)
Browse files Browse the repository at this point in the history
This can be triggered if the result backend isn't set which
unfortunately took a long time for me to sort out because
the error message was so ambiguous.
  • Loading branch information
jrpotter authored and codingjoe committed Oct 19, 2018
1 parent 43f03bc commit ac7d619
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions health_check/contrib/celery/backends.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,7 @@ def check_status(self):
self.add_error(ServiceReturnedUnexpectedResult("Celery returned wrong result"))
except IOError as e:
self.add_error(ServiceUnavailable("IOError"), e)
except NotImplementedError as e:
self.add_error(ServiceUnavailable("NotImplementedError: Make sure CELERY_RESULT_BACKEND is set"), e)
except BaseException as e:
self.add_error(ServiceUnavailable("Unknown error"), e)

0 comments on commit ac7d619

Please sign in to comment.