Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop separately tracking focus for Input #859

Merged
merged 9 commits into from
May 27, 2020
Merged

Stop separately tracking focus for Input #859

merged 9 commits into from
May 27, 2020

Conversation

ericluap
Copy link
Contributor

I renamed dispatch to focus and focus to focusWithoutBlur.

(I accidentally screwed up the other pull request.)

I ran esy format and it didn't change anything, but hopefully it's happy now. I also am not sure what the unused variable mentioned is.

Et7f3
Et7f3 reviewed May 24, 2020
View reviewed changes
src/UI_Components/Input.re Outdated Show resolved Hide resolved
@ericluap ericluap requested a review from Et7f3 May 24, 2020 19:57
glennsl
glennsl reviewed May 25, 2020
View reviewed changes
src/UI/Focus.re Outdated Show resolved Hide resolved
ericluap added 2 commits May 25, 2020 12:18
@ericluap
Add interface for Focus
d61321d
@ericluap
Stick with reducer
1e80aec 
Using reducer instead of state hook because of possible bug with state
hooks (briskml/brisk-reconciler#74).
glennsl
glennsl reviewed May 26, 2020
View reviewed changes
Copy link
Member

@glennsl glennsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the interface! That makes the boundary much more apparent, and exposes other potential issues like bad encapsulation. Based on that I have one more suggestion below.

src/UI/Focus.rei Outdated Show resolved Hide resolved
glennsl
glennsl reviewed May 26, 2020
View reviewed changes
Copy link
Member

@glennsl glennsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an unused variable warning that causes the CI to fail. You can run esy dune build @check locally to emit all warnings.

src/UI/Keyboard.re Outdated Show resolved Hide resolved
glennsl
glennsl approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@glennsl glennsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for cleaning this up!

@glennsl glennsl merged commit e5f363a into revery-ui:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennsl glennsl glennsl approved these changes

@Et7f3 Et7f3 Awaiting requested review from Et7f3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericluap @glennsl @Et7f3