Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use curl --compressed argument if Accept-Encoding includes gzip #439

Closed
wants to merge 0 commits into from

Conversation

sheimer
Copy link

@sheimer sheimer commented Sep 3, 2024

Adds --compressed argument automatically, if header Accept-Encoding is present and includes gzip.

A new builder method builder.extras is used to add the argument.

Solves problem #435

@boltlessengineer
Copy link
Contributor

I think I misunderstood about --compressed option.
This should be opt-in feature instead of opt-out.

@boltlessengineer
Copy link
Contributor

@sheimer I added clients.curl.opts.set_compressed option which is false by default.
You can enable this option to set --compressed argument when Accept-Encoding header contains ”gzip”.

If you are fine with this opt-in implementation, I’ll merge the PR.

@sheimer
Copy link
Author

sheimer commented Sep 3, 2024

I am totally fine with this opt-in option on the client! Thank you very much :)

@boltlessengineer
Copy link
Contributor

Oops I messed up the branches while rebasing it. This is merged to main now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants