fix(render): pretty option including extra < in the Button
#1881
+85
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2e2ae98 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bukinoshita
reviewed
Jan 27, 2025
gabrielmfern
force-pushed
the
canary
branch
2 times, most recently
from
81c08e3 to
301f54b
Compare
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: gabriel miranda <[email protected]>
gabrielmfern
force-pushed
the
feature/eng-3802-fix-issue-with-prettier-and-the-if-mso-comments
branch
from
2f49ed0 to
fa4a5aa
Compare
bukinoshita
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that, for some reason, Prettier's HTML printer inserts the ending
</spanmanuallywhen printing the
if msocomment, and that ending tag was not being inserted on our side. It alsoseems to be inserted under some obscure conditions that would be way too hard for us to replicate.
https://github.com/prettier/prettier/blob/3e2f487049eff356bb7c766cfc40a7088019d3f6/src/language-html/print/tag.js#L42-L53
The solution I opted into was to run the original printing function, and then do our required changes
on Prettier
Docs. The changes were to simply map recursively through the entire returnedDocand convertall
lineDocs to either a space or nothing based on whether it is a soft line or not.