Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade node to v22.13 LTS #1383

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Upgrade node to v22.13 LTS #1383

merged 2 commits into from
Jan 30, 2025

Conversation

dmijatovic
Copy link
Contributor

@dmijatovic dmijatovic commented Jan 28, 2025

Upgrade to node v22.13.1 LTs

Closes #1368
Closes #1376

Changes proposed in this pull request:

  • Upgrade node to latest LTS version
    * backend-postgrest/test (v17-alpine): REMOVED
    * data-generation (v22.5.1): DONE
    * documentation (v20.5): DONE, dependencies updated too
    * frontend (v20.10): done in 1287 remote rsd search (RSD v3) #1356
  • Update actions to use same node version (v22.13)
    * all_tests.yml: 20.10 - DONE
    * e2e_tests_*.yml: 20.10 - DONE
    * frontend_tests.yml: 20.10: done in 1287 remote rsd search (RSD v3) #1356
    * prettier-check-data-generation.yml: 20.x - DONE

How to test:

  • make start to build and generate test data
  • all processes should work as before
  • github actions should work too (this is difficult to test so we will need to see them in action over the time)

Advised node version on your local machine

  • Upgrade node to v22.13.1 lts
  • Upgrade npm to v11.0.0

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

Copy link
Collaborator

@ewan-escience ewan-escience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're already behind, version 22.13.1 is already released! ;) Since this is a patch version, it should be easy to upgrade. Otherwise, nice work. :)

Copy link

@dmijatovic dmijatovic merged commit 3f3fff1 into main Jan 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gthub actions cache update Upgrade node to last LTS version (22.13)
3 participants