Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable web viewer file check in ci #8834

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Disable web viewer file check in ci #8834

merged 1 commit into from
Jan 27, 2025

Conversation

oxkitsune
Copy link
Contributor

@oxkitsune oxkitsune commented Jan 27, 2025

Related

What

Adds a cfg flag to the web viewer check, to make CI happy again

  • passes full ci check

@oxkitsune oxkitsune added exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI labels Jan 27, 2025
@oxkitsune oxkitsune self-assigned this Jan 27, 2025
@oxkitsune oxkitsune changed the title Disable web viewer check in ci Disable web viewer file check in ci Jan 27, 2025
Copy link

github-actions bot commented Jan 27, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
a8cf09d https://rerun.io/viewer/pr/8834 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf
Copy link
Member

Wumpf commented Jan 27, 2025

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/12996005059

@Wumpf Wumpf merged commit fd69df3 into main Jan 27, 2025
71 of 73 checks passed
@Wumpf Wumpf deleted the gijs/fix-ci-with-new-hint branch January 27, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚢 CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants