Fix mesh casting color components incorrectly #8807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
🦟 regression
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Wumpf
changed the title
emilk
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messed up the swizzling of colors when doing to aggressive bytemuck slice casts. Causing this
This pr gets us back to
What did we re-learn today that we knew all along but didn't pay attention to?
Our user facing API says
The color is stored as a 32-bit integer, where the most significant byte isRand the least significant byte isA.- which allows you to write0xFF00FFFFfor a beautiful magenta and is what everyone is used to. But written as an array this is[a, b, g, r]because most of the world is little endian and that means that the least significant byte (alpha!) comes first. But in rendering (that includes re_renderer & egui) everything is[r,g,b,a]!