Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clicking of links in markdown #8794

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

emilk
Copy link
Member

@emilk emilk commented Jan 23, 2025

Related

What

The text document had a response.interact(Sense::click()) call on top of it, catching all clicks that should have ended up on the hyperlinks. This is now changed into setting Sense::click on the underlying Ui when creating it, meaning it will catch clicks behind the hyperlinks, i.e. any click that doesn't interact with the document iteself.

@emilk emilk added 🪳 bug Something isn't working ui concerns graphical user interface 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release include in changelog egui Requires egui/eframe work labels Jan 23, 2025
Copy link

github-actions bot commented Jan 23, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
d030c6c https://rerun.io/viewer/pr/8794 +nightly +main

Note: This comment is updated whenever you push a commit.

@abey79 abey79 self-requested a review January 24, 2025 08:09
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on testing with the web build and comparing with the last release, this does fix the clicking on link. However, clicking in the "void" no longer selects the text view like it use to do. I think this is an unwanted regression.

@abey79
Copy link
Member

abey79 commented Jan 24, 2025

Also, there is a perma-horizontal scroll bar in the view, at least in the DNA example. This is not new though, same in 0.21.

image

@emilk
Copy link
Member Author

emilk commented Jan 24, 2025

However, clicking in the "void" no longer selects the text view like it use to do

it-works-on-my-computer

It works for me O.o

@abey79
Copy link
Member

abey79 commented Jan 24, 2025

It works for me O.o

what the heck? I tried TWICE, and now it's working for me too. No idea what happened... I should take a day off 😞

@emilk emilk merged commit b8856d8 into main Jan 24, 2025
43 checks passed
@emilk emilk deleted the emilk/fix-clicking-markdown-links branch January 24, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working egui Requires egui/eframe work include in changelog 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links in markdown don't work
2 participants