Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Image & Mesh3D archetypes in Rust eager serialized #8793

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 23, 2025

Related

( fixes only if #8789 lands as well)

What

Similar to the previous PRs. These two had a few touching points, so this comes in bulk.
Led actually to a few nice cleanups around Meshes. Image cache on the other hand got a little bit hairy, resolved this by moving some extensions from the archetype down to the components.

No breaking changes & deprecations.

Next step: Remove "attr.rust.archetype_eager", making this always on.

  • pass full check ci

Copy link

github-actions bot commented Jan 23, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
64258c2 https://rerun.io/viewer/pr/8793 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf
Copy link
Member Author

Wumpf commented Jan 23, 2025

oops, some todos left in there that indicate I wanted to test some stuff there first

@Wumpf Wumpf marked this pull request as draft January 23, 2025 17:31
@Wumpf Wumpf marked this pull request as ready for review January 23, 2025 17:52
@Wumpf
Copy link
Member Author

Wumpf commented Jan 23, 2025

indeed testing with raw_mesh rust example unearthed some issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant