Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "applicable" to "maybe visualizable" and adjust various docs accordingly #8767

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 21, 2025

Related

What

See title.
Hopefully this makes things less confusing in the future. Went through all the mentions of "applicable" & "applicability" in all *.rs files and tried to set things right.

Small nuance that goes a bit further: the custom bit of "maybe visualizable" set (former applicability) is now called DataBasedVisualizabilityFilter - the "maybe" part here is dropped (but documented) since it shouldn't really matter! What it does is what it says now: It's a hermetic function that can only take into account component data but no other context.

@Wumpf Wumpf added 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 21, 2025
@Wumpf Wumpf force-pushed the andreas/rename-applicability-to-maybevisualizable branch from 38dc4f5 to 3bab99b Compare January 21, 2025 17:00
Copy link

github-actions bot commented Jan 21, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
22c3d16 https://rerun.io/viewer/pr/8767 +nightly +main

Note: This comment is updated whenever you push a commit.

Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Wumpf Wumpf force-pushed the andreas/rename-applicability-to-maybevisualizable branch from b690802 to 22c3d16 Compare January 22, 2025 08:48
@Wumpf Wumpf merged commit 5dcb63f into main Jan 22, 2025
31 checks passed
@Wumpf Wumpf deleted the andreas/rename-applicability-to-maybevisualizable branch January 22, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md 🚜 refactor Change the code, not the functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants