Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wgpu to 24.0.0 #8743

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Update wgpu to 24.0.0 #8743

merged 4 commits into from
Jan 21, 2025

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Jan 20, 2025

With minimal changes along the way.

  • pixi run js-build-base still works
    • @jprochazk : We've been through this before, but we didn't fix up the comments on wasm-bindgen: It says "make sure the build script still works". Well it runs, but how do I make sure the output makes sense? I remember us diffing a bunch of things, but not what it was. As-is that comment just makes me nervous without being actionable
  • tested a bunch of examples on native MacOS
  • tested web

All glitches I found are documented in #8723 and are on main as well.

@Wumpf Wumpf added dependencies concerning crates, pip packages etc include in changelog labels Jan 20, 2025
Copy link

github-actions bot commented Jan 20, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
4dca724 https://rerun.io/viewer/pr/8743 +nightly +main

Note: This comment is updated whenever you push a commit.

@Wumpf Wumpf changed the title Update egui, wgpu & wasm-bindgen Update wgpu to 24.0.0 Jan 20, 2025
@Wumpf Wumpf marked this pull request as ready for review January 20, 2025 17:45
@jprochazk jprochazk added the wasm-bindgen version update Version of `wasm-bindgen` changed. Our JS package is highly sensitive to its output! label Jan 20, 2025
@jprochazk
Copy link
Member

I remember us diffing a bunch of things, but not what it was. As-is that comment just makes me nervous without being actionable

It works if the build script text replacements actually have an effect on the built Wasm. I realise that there's no easy way to check that, ideally it would be a pixi command that builds the Wasm, applies our patch, and diffs the two to confirm the changes were applied.

Something like:

mkdir rerun_js/web-viewer/temp
pixi run cargo run -p re_dev_tools -- build-web-viewer --release -g \
  --target no-modules-base \
  --no-default-features \
  --features grpc,map_view \
  -o rerun_js/web-viewer/temp
pixi run js-build-base
git diff --no-index rerun_js/web-viewer/re_viewer.js rerun_js/web-viewer/temp/re_viewer.js
rm -rf rerun_js/web-viewer/temp

@Wumpf Wumpf merged commit 9437f4f into main Jan 21, 2025
31 checks passed
@Wumpf Wumpf deleted the andreas/update-egui branch January 21, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies concerning crates, pip packages etc include in changelog wasm-bindgen version update Version of `wasm-bindgen` changed. Our JS package is highly sensitive to its output!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants