Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store: get rid of query_id #8739

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Store: get rid of query_id #8739

merged 1 commit into from
Jan 20, 2025

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jan 20, 2025

We haven't used query_id for anything in ages, and as such its implementation has bitrotted into inconsistency, and now it's unreliable.

Get rid of it.

@teh-cmc teh-cmc added ⛃ re_datastore affects the datastore itself 🚜 refactor Change the code, not the functionality exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jan 20, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 20, 2025 •
edited
Loading

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
✅ 1f61ce3 https://rerun.io/viewer/pr/8739 +nightly +main

Note: This comment is updated whenever you push a commit.

@teh-cmc teh-cmc merged commit 4948ee8 into main Jan 20, 2025
37 checks passed
@teh-cmc teh-cmc deleted the cmc/rm_query_id branch January 20, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
exclude from changelog PRs with this won't show up in CHANGELOG.md ⛃ re_datastore affects the datastore itself 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@teh-cmc