Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve clippy::unwrap_used in re_types_core #8732

Merged
merged 1 commit into from
Jan 22, 2025
Merged

resolve clippy::unwrap_used in re_types_core #8732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions crates/store/re_types_core/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@
#![doc = document_features::document_features!()]
//!

// TODO(#6330): remove unwrap()
#![allow(clippy::unwrap_used)]

// ---

/// Number of decimals shown for all float display methods.
Expand Down
3 changes: 3 additions & 0 deletions crates/store/re_types_core/src/tuid.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ impl Loggable for Tuid {
// NOTE: Unwrap is safe everywhere below, datatype is checked above.
// NOTE: We don't even look at the validity, our datatype says we don't care.

#[allow(clippy::unwrap_used)]
let array = array.downcast_array_ref::<StructArray>().unwrap();

// TODO(cmc): Can we rely on the fields ordering from the datatype? I would assume not
Expand All @@ -95,10 +96,12 @@ impl Loggable for Tuid {
inc_index = Some(i);
}
}
#[allow(clippy::unwrap_used)]
(time_ns_index.unwrap(), inc_index.unwrap())
};

let get_buffer = |field_index: usize| {
#[allow(clippy::unwrap_used)]
array.columns()[field_index]
.downcast_array_ref::<UInt64Array>()
.unwrap()
Expand Down
Loading