resolve clippy::unwrap_used in re_types_core #8732
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
Part of: #6330
What
#![allow(clippy::unwrap_used)]
& TODO comment fromcrates/store/re_types_core/src/lib.rs
#[allow(clippy::unwrap_used)]
directives toTuid::from_arrow
fn incrates/store/re_types_core/src/tuid.rs
RATIONALE:
Given the following comment in
Tuid::from_arrow
:// NOTE: Unwrap is safe everywhere below, datatype is checked above.
I figured it would be easiest & cleanest to simply add the focused
#[allow(clippy::unwrap_used)]
directives into theTuid::from_arrow
fn. I did consider some other possible refactoring but decided against this.Incidentally when I did try injecting a couple mutations,
cargo test -p re_types_core --all-features
continued to succeed with these: