Remove use of into_arrow2_buffer in generated code
#8731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🏹 arrow
|
@rerun-bot full-check |
emilk
changed the title
into_arrow2_buffer in generated code
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/12856032271 |
|
Web viewer failed to build. | Result | Commit | Link | Manifest | Note: This comment is updated whenever you push a commit. |
teh-cmc
approved these changes
Jan 20, 2025
Comment on lines
629
to
639
| // Offsets is always non-empty. The last element is the total length of buffer we need. | ||
| #[allow(clippy::unwrap_used)] | ||
| let capacity = offsets.last().copied().unwrap() as usize; | ||
|
|
||
| let mut buffer_builder = arrow::array::builder::BufferBuilder::<u8>::new(capacity); | ||
| // NOTE: Flattening to remove the guaranteed layer of nullability: we don't care | ||
| // about it while building the backing buffer since it's all offsets driven. | ||
| let inner_data: arrow::buffer::Buffer = | ||
| #data_src.into_iter().flatten() #quoted_transparent_mapping.collect(); | ||
| for data in #data_src.iter().flatten() { | ||
| buffer_builder.append_slice(data #quoted_member_accessor.as_bytes()); | ||
| } | ||
| let inner_data: arrow::buffer::Buffer = buffer_builder.finish(); |
There was a problem hiding this comment.
I'm surprised we can't just use a collect() here and below, Buffer seems to implement `FromIterator?
There was a problem hiding this comment.
We can, but I wanted to pre-allocate (reserve) the exact amount of bytes we need.
I'll add a comment explaining this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re_arrow2toarrow#3741