Skip to content

Commit

Permalink
link to ticket on wasm-bindgen warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
Wumpf committed Jan 21, 2025
1 parent fa87b18 commit 4dca724
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
3 changes: 2 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -302,11 +302,12 @@ uuid = "1.1"
vec1 = "1.8"
walkdir = "2.0"
walkers = "0.32"
# NOTE: `rerun_js/web-viewer/build-wasm.mjs` is HIGHLY sensitive to changes in `wasm-bindgen`.
# TODO(#8766): `rerun_js/web-viewer/build-wasm.mjs` is HIGHLY sensitive to changes in `wasm-bindgen`.
# Whenever updating `wasm-bindgen`, update this and the narrower dependency specifications in
# `crates/viewer/re_viewer/Cargo.toml`, and make sure that the build script still works.
# Do not make this an `=` dependency, because that may break Rust users’ builds when a newer
# version is released, even if they are not building the web viewer.
# For details see https://github.com/rerun-io/rerun/issues/8766
wasm-bindgen = "0.2.100"
wasm-bindgen-cli-support = "=0.2.100"
wasm-bindgen-futures = "0.4.50"
Expand Down
9 changes: 6 additions & 3 deletions crates/viewer/re_viewer/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,12 @@ js-sys.workspace = true
strum.workspace = true
strum_macros.workspace = true
wasm-bindgen-futures.workspace = true
# NOTE: `rerun_js/web-viewer/build-wasm.mjs` is HIGHLY sensitive to changes in `wasm-bindgen`.
# Whenever updating `wasm-bindgen`, update this and the broader dependency specifications in
# the root `/Cargo.toml`, and make sure that the output of `pixi run js-build-base` still works.
# TODO(#8766): `rerun_js/web-viewer/build-wasm.mjs` is HIGHLY sensitive to changes in `wasm-bindgen`.
# Whenever updating `wasm-bindgen`, update this and the narrower dependency specifications in
# `crates/viewer/re_viewer/Cargo.toml`, and make sure that the build script still works.
# Do not make this an `=` dependency, because that may break Rust users’ builds when a newer
# version is released, even if they are not building the web viewer.
# For details see https://github.com/rerun-io/rerun/issues/8766
wasm-bindgen = "=0.2.100"
web-sys = { workspace = true, features = [
"History",
Expand Down

0 comments on commit 4dca724

Please sign in to comment.