editor: fix can remove field when a hide expression exists

* Avoids the possiblity to remove or add a field with an hide expression (tash button on the label component). * Adds an exemple in the demo editor. * Does not add a field with an hide expression during the edit initialization. In the previous versions the field was in the editor and in the completion menu. Co-Authored-by: Johnny Mariéthoz <[email protected]>
rero · Jul 25, 2024 · 2e53c6c · 2e53c6c
1 parent 3a0bc78
commit 2e53c6c
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 1 deletion.
diff --git a/projects/ng-core-tester/src/app/record/editor/schema.json b/projects/ng-core-tester/src/app/record/editor/schema.json
@@ -10,6 +10,7 @@
     "oneOf",
     "optional",
     "required",
+    "optional_hide_expression_field",
     "essential",
     "hidden",
     "defaultHidden",
@@ -251,6 +252,21 @@
         }
       }
     },
+    "optional_hide_expression_field": {
+      "title": "Optional Field with Hide Expression",
+      "type": "string",
+      "minLength": 3,
+      "widget": {
+        "formlyConfig": {
+          "expressions": {
+            "hide": "!field.parent.model.required"
+          },
+          "props": {
+            "doNotSubmitOnEnter": true
+          }
+        }
+      }
+    },
     "enum": {
       "title": "List of values",
       "type": "string",

diff --git a/projects/rero/ng-core/src/lib/record/editor/editor.component.ts b/projects/rero/ng-core/src/lib/record/editor/editor.component.ts
@@ -767,7 +767,8 @@ export class EditorComponent extends AbstractCanDeactivateComponent implements O
     }
     return (
       !field.props.required &&
-      !field.hide
+      !field.hide &&
+      !('hide' in field?.expressions)
     );
   }
 

diff --git a/projects/rero/ng-core/src/lib/record/editor/extensions.ts b/projects/rero/ng-core/src/lib/record/editor/extensions.ts
@@ -219,6 +219,8 @@ export class NgCoreFormlyExtension {
       // ignore array item which as key of the form "0"
       // TODO: find a better way to identify this case
       || !isNaN(Number(field.key))
+      // ignore field that has hide expression
+      || ('hide' in field?.expressions)
       // do not hide a field containing a 'hide' wrapper
       || this._hasHideWrapper(field)
       // do not hide a field that has a parent marked as hidden and a model is empty