Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPMRPP-96014 || Delete project in organization #4088

Conversation

maria-hambardzumian
Copy link
Contributor

@maria-hambardzumian maria-hambardzumian commented Nov 8, 2024

PR Checklist

  • Have you verified that the PR is pointing to the correct target branch? (develop for features/bugfixes, other if mentioned in the task)
  • Have you verified that your branch is consistent with the target branch and has no conflicts? (if not, make a rebase under the target branch)
  • Have you checked that everything works within the branch according to the task description and tested it locally?
  • Have you run the linter (npm run lint) prior to submission? Enable the git hook on commit in your IDE to run it and format the code automatically.
  • Have you run the tests locally and added/updated them if needed?
  • Have you checked that app can be built (npm run build)?
  • Have you checked that no new circular dependencies appreared with your changes? (the webpack plugin reports circular dependencies within the dev npm script)
  • Have you made sure that all the necessary pipelines has been successfully completed?
  • If the task requires translations to be updated, have you done this by running the manage:translations script?

Visuals

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.00%. Comparing base (23a66d2) to head (ca8e29f).

Files with missing lines Patch % Lines
...pp/src/common/utils/validation/commonValidators.js 0.00% 2 Missing ⚠️
app/src/common/utils/validation/validate.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           feature/orgs    #4088      +/-   ##
================================================
- Coverage         61.12%   61.00%   -0.12%     
================================================
  Files                84       84              
  Lines               926      931       +5     
  Branches            134      134              
================================================
+ Hits                566      568       +2     
- Misses              329      332       +3     
  Partials             31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 8, 2024

@maria-hambardzumian maria-hambardzumian merged commit f2eb7ce into feature/orgs Nov 8, 2024
7 checks passed
@maria-hambardzumian maria-hambardzumian deleted the feature/EPMRPP-96014-Delete-project-in-organization branch November 8, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants